Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numcodec version in pyproject.toml #163

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Update numcodec version in pyproject.toml #163

merged 3 commits into from
Feb 13, 2024

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Feb 13, 2024

Motivation

Fix #162

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f180b44) 86.04% compared to head (e576683) 86.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #163   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files           5        5           
  Lines        1161     1161           
  Branches      296      296           
=======================================
  Hits          999      999           
  Misses        107      107           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel marked this pull request as ready for review February 13, 2024 18:54
@oruebel oruebel requested a review from stephprince February 13, 2024 18:54
@oruebel oruebel merged commit 8d93c0f into dev Feb 13, 2024
24 checks passed
@oruebel oruebel deleted the up/numcodec_version branch February 13, 2024 20:45
@oruebel oruebel mentioned this pull request Feb 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove strict dependency for numcodecs to support python 3.12
3 participants