-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve h5py.Dataset filter settings on export #153
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #153 +/- ##
==========================================
+ Coverage 84.51% 85.07% +0.56%
==========================================
Files 5 5
Lines 1104 1146 +42
Branches 296 311 +15
==========================================
+ Hits 933 975 +42
Misses 115 115
Partials 56 56 ☔ View full report in Codecov by Sentry. |
@rly @mavaylon1 can you please review |
The code looks good to me. There are a bunch of branches in the code that translates the compression. I know it's tedious, but could you write tests for those branches? That would help make sure those lines work as intended and prevent our code coverage from dropping 1% to 83.4%. We might want to include hdmf-zarr in our core packages for the U24 at some point. |
The main reason I didn't add tests for all the branches is because in order to cover those cases I believe we need to install custom HDF5 compressors, i.e., add |
I think that is OK. It would be added to https://github.com/hdmf-dev/hdmf-zarr/blob/dev/requirements-dev.txt
We can just exclude that one from coverage |
@rly Can you please take another look. I added a new unit test module for |
Thanks! Looks good to me. |
Motivation
Fix #152 Preserve h5py.Dataset filter settings on export
How to test the behavior?
ZarrDataIO
to wraph5py.Dataset
and infer filter settingsZarrIO
to wraph5py.Dataset
on write to preserve filter settingsChecklist
ruff
from the source directory.