Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml and remove setup.py #143

Merged
merged 30 commits into from
Dec 7, 2023
Merged

Update pyproject.toml and remove setup.py #143

merged 30 commits into from
Dec 7, 2023

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Nov 27, 2023

  • Update version control to hatch backend
  • Update pytest, coverage, and ruff via pyproject.toml
  • Add ruff and codespell

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9c3b4be) 86.45% compared to head (246f105) 84.51%.

Files Patch % Lines
src/hdmf_zarr/backend.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #143      +/-   ##
==========================================
- Coverage   86.45%   84.51%   -1.95%     
==========================================
  Files          14        5       -9     
  Lines        3279     1104    -2175     
  Branches        0      296     +296     
==========================================
- Hits         2835      933    -1902     
+ Misses        444      115     -329     
- Partials        0       56      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

Fix #110, #91

@mavaylon1
Copy link
Contributor Author

Note: I built locally and the version is correct. Let's aim for a release to test the real thing. (After other PRs are also merged)

@mavaylon1 mavaylon1 marked this pull request as ready for review December 5, 2023 00:47
@mavaylon1 mavaylon1 requested review from rly and oruebel December 5, 2023 00:48
@oruebel
Copy link
Contributor

oruebel commented Dec 5, 2023

Thanks @mavaylon1. @rly could you please review this one. I think it looks good but you are more familiar with the versioning and deployment workflows.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@rly
Copy link
Contributor

rly commented Dec 5, 2023

Please delete setup.py

@rly
Copy link
Contributor

rly commented Dec 5, 2023

Please also delete setup.cfg

@rly
Copy link
Contributor

rly commented Dec 5, 2023

Please update the required checks so that flake8 is not required but ruff is.

rly
rly previously approved these changes Dec 5, 2023
@mavaylon1
Copy link
Contributor Author

@rly I deleted flake8 can you approve again.

@mavaylon1 mavaylon1 merged commit 5e48ab5 into dev Dec 7, 2023
24 checks passed
@mavaylon1 mavaylon1 deleted the toml branch December 7, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants