Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy degrade for python 3.7 #115

Merged
merged 13 commits into from
Aug 22, 2023
Merged

numpy degrade for python 3.7 #115

merged 13 commits into from
Aug 22, 2023

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Aug 19, 2023

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Update python that supports 3.7. This is meant to address the fact that the Read the Docs for HDMF-Zarr does not build.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the tests and check read the docs build

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (086c9bc) 81.92% compared to head (90e8537) 81.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #115   +/-   ##
=======================================
  Coverage   81.92%   81.92%           
=======================================
  Files          11       11           
  Lines        2667     2667           
=======================================
  Hits         2185     2185           
  Misses        482      482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Contributor

rly commented Aug 19, 2023

As a quick fix, this is fine but we also do not need to support Python 3.7 anymore unless there is a good reason to. We have migrated HDMF to Python 3.8 minimum.

@mavaylon1
Copy link
Contributor Author

mavaylon1 commented Aug 19, 2023

As a quick fix, this is fine but we also do not need to support Python 3.7 anymore unless there is a good reason to. We have migrated HDMF to Python 3.8 minimum.

Correct and there is a PR to make that upgrade (#105). What made us stop was the fact the export/cache bug preventing us from using a more recent version of HDMF to then drop 3.7. @rly

@mavaylon1
Copy link
Contributor Author

@oruebel @rly This does fix this build issue. I will clean it up tomorrow. I am aware of 3.7 being dropped and the export/cache issue is the main bump we will get through to bring hdmf-zarr up to speed with hdmf.

@mavaylon1 mavaylon1 self-assigned this Aug 22, 2023
@mavaylon1 mavaylon1 added the category: bug errors in the code or code behavior label Aug 22, 2023
@mavaylon1 mavaylon1 marked this pull request as ready for review August 22, 2023 15:53
@mavaylon1 mavaylon1 requested a review from oruebel August 22, 2023 15:53
@mavaylon1 mavaylon1 merged commit 6c13e14 into dev Aug 22, 2023
@mavaylon1 mavaylon1 deleted the numpy3.7 branch August 22, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants