-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy degrade for python 3.7 #115
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev #115 +/- ##
=======================================
Coverage 81.92% 81.92%
=======================================
Files 11 11
Lines 2667 2667
=======================================
Hits 2185 2185
Misses 482 482 ☔ View full report in Codecov by Sentry. |
As a quick fix, this is fine but we also do not need to support Python 3.7 anymore unless there is a good reason to. We have migrated HDMF to Python 3.8 minimum. |
Correct and there is a PR to make that upgrade (#105). What made us stop was the fact the export/cache bug preventing us from using a more recent version of HDMF to then drop 3.7. @rly |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Update python that supports 3.7. This is meant to address the fact that the Read the Docs for HDMF-Zarr does not build.
How to test the behavior?
Run the tests and check read the docs build
Checklist
ruff
from the source directory.