Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict dependency for numcodecs to support python 3.12 #162

Closed
h-mayorquin opened this issue Feb 13, 2024 · 2 comments · Fixed by #163
Closed

Remove strict dependency for numcodecs to support python 3.12 #162

h-mayorquin opened this issue Feb 13, 2024 · 2 comments · Fixed by #163

Comments

@h-mayorquin
Copy link

We are failing to support python 3.12 in neuroconv because hdmf-zarr has the following hard pin on numcodecs:

hdmf-zarr/pyproject.toml

Lines 34 to 35 in 300070b

'numcodecs>=0.9.1',
'numcodecs==0.11.0',

(it also seems to be repeated)

Could we make this a soft dependency on the version?

numcodecs 0.12 introduced python 3.12 support:
https://numcodecs.readthedocs.io/en/stable/release.html

I can push a PR to change this but I just wanted to discuss this before.

@oruebel
Copy link
Contributor

oruebel commented Feb 13, 2024

it also seems to be repeated

Thanks for the catch, that look like a bug

Could we make this a soft dependency on the version

Having a soft dependency should be fine. I'm not sure what the lowest version is that we should allow for numcodecs, but I think >=0.11.0 should be fine.

@oruebel
Copy link
Contributor

oruebel commented Feb 13, 2024

Looking at the minimum requirements, we are testing with 'numcodecs==0.9.1', so I'll make that the minimum.

numcodecs==0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants