Skip to content

Commit

Permalink
Merge branch 'ref' of https://github.com/hdmf-dev/hdmf-zarr into ref
Browse files Browse the repository at this point in the history
  • Loading branch information
mavaylon1 committed Sep 29, 2023
2 parents a9537df + 9de5bba commit 67db293
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/run_all_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ jobs:
run: |
conda config --set always_yes yes --set changeps1 no
conda info
# the conda dependency resolution for tox under python 3.8 can install the wrong importlib_metadata
conda install -c conda-forge tox "importlib_metadata>4"
conda install -c conda-forge tox
- name: Conda reporting
run: |
Expand Down
3 changes: 2 additions & 1 deletion src/hdmf_zarr/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -586,13 +586,14 @@ def __get_ref(self, ref_object, export_source=None):
else self.source)

# Make the source relative to the current file
source = os.path.relpath(os.path.abspath(source), start=self.abspath)
# TODO: This check assumes that all links are internal links on export.
# Need to deal with external links on export.
if export_source is not None:
# Make sure the source of the reference is now towards the new file
# and not the original source when exporting.
source = '.'
else:
source = os.path.relpath(os.path.abspath(source), start=self.abspath)
# Return the ZarrReference object
return ZarrReference(source, path)

Expand Down

0 comments on commit 67db293

Please sign in to comment.