Skip to content

Commit

Permalink
feedback fix
Browse files Browse the repository at this point in the history
  • Loading branch information
mavaylon1 committed Sep 29, 2023
2 parents 1a4014d + e25e1a7 commit 018e9e4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# HDMF-ZARR Changelog

## 0.3.1 (Upcoming)
## 0.4.0 (Upcoming)

### Enhancements
* Enhanced ZarrIO to resolve object references lazily on read similar to HDMF's `HDF5IO` backend @mavaylon1 [#120](https://github.com/hdmf-dev/hdmf-zarr/pull/120)
Expand Down
5 changes: 5 additions & 0 deletions src/hdmf_zarr/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,11 @@ def write_dataset(self, **kwargs): # noqa: C901
dset = self.__list_fill__(parent, name, data, options)
# Write a dataset of references
elif self.__is_ref(options['dtype']):
# TODO Region references are not yet support, but here how the code should look
# if isinstance(data, RegionBuilder):
# shape = (1,)
# type_str = 'region'
# refs = self.__get_ref(data.builder, data.region)
if isinstance(data, ReferenceBuilder):
shape = (1,)
type_str = 'object'
Expand Down

0 comments on commit 018e9e4

Please sign in to comment.