[client] avoid doing anything in app extensions

hbang · Jun 19, 2017 · e228e88 · e228e88
1 parent e49284e
commit e228e88
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/client/Client.x b/client/Client.x
@@ -199,9 +199,17 @@
 #pragma mark - Constructor
 
 %ctor {
-	NSString *bundleIdentifier = [NSBundle mainBundle].bundleIdentifier;
-
-	if ([bundleIdentifier isEqualToString:@"com.apple.accessibility.AccessibilityUIServer"] || [bundleIdentifier isEqualToString:@"com.apple.SafariViewService"]) {
+	NSBundle *bundle = [NSBundle mainBundle];
+	NSString *bundleIdentifier = bundle.bundleIdentifier;
+	NSDictionary <NSString *, id> *infoPlist = bundle.infoDictionary;
+
+	// blacklist:
+	// • AccessibilityUIServer (has no status bar anyway)
+	// • SafariViewService (no idea why it crashes…)
+	// • app extensions/plugins (can have a pretty locked down sandbox)
+	if ([bundleIdentifier isEqualToString:@"com.apple.accessibility.AccessibilityUIServer"]
+		|| [bundleIdentifier isEqualToString:@"com.apple.SafariViewService"]
+		|| infoPlist[@"NSExtension"] || infoPlist[@"PlugInKit"]) {
 		return;
 	}