Add basic URL Encoding for scratchpad text state #1441
Conversation
| // Override the load function | ||
| let load = (): t => { | ||
| switch (JsUtil.QueryParams.get_param(key_string)) { | ||
| | Some(data) => | ||
| let decompressed = StringUtil.decompress(data); | ||
| let zip = Haz3lcore.Printer.zipper_of_string(decompressed); | ||
| switch (zip) { | ||
| | Some(zip) => (0, [PersistentZipper.persist(zip)]) | ||
| | None => init() | ||
| }; | ||
| | None => | ||
| switch (JsUtil.get_localstore(key_string)) { | ||
| | None => init() | ||
| | Some(data) => deserialize(data, default()) | ||
| } | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
This blows away all the scratch buffers a user currently has. Not sure how we want to handle it. We could create a new scratch buffer or maybe highjack the active one?
There was a problem hiding this comment.
I think my ideal solution here is for the URL to encode some arbitrary partial state -- some of which could be a named scratchpad added to the editor state -- maybe the default names would be protected to prevent malicious links deleting existing work.
Alternatively (and more easily), we could have some "visitor" mode in which your state isn't persisted through traditional methods, and some option to merge the visitor state with your local state.
There was a problem hiding this comment.
I wonder if the easiest thing is to just add a third section under scratch and documentation that only shows up if you're using the share url.
There was a problem hiding this comment.
lol... you're totally right, that's way easier
This branch implements a basic mechanism to encode and retrieve the text state of a scratchpad:
Currently, this takes precedence over the local store.
Example: prime finder
Future potential improvements: