Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try declaring a regular recursive type for exp as opposed to the recursive modules #1391

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

7h3kk1d
Copy link
Contributor

@7h3kk1d 7h3kk1d commented Sep 12, 2024

Necessary for deriving qcheck and also removes redundancy when adding language features.

@7h3kk1d 7h3kk1d changed the title In progress commit Try declaring a regular recursive type for exp as opposed to the recursive modules Sep 12, 2024
@@ -42,16 +46,126 @@ let stop = (_, x) => x;
the id of the closure.
*/

[@deriving (show({with_path: false}), sexp, yojson)]
type any_t =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the encoding

@7h3kk1d 7h3kk1d requested a review from Negabinary September 12, 2024 17:59
@7h3kk1d 7h3kk1d marked this pull request as ready for review September 12, 2024 17:59
Copy link
Contributor

@Negabinary Negabinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@7h3kk1d 7h3kk1d requested a review from cyrus- October 7, 2024 13:44
@7h3kk1d
Copy link
Contributor Author

7h3kk1d commented Nov 1, 2024

@cyrus- @disconcision said he's fine with this change so merge whenever

@cyrus- cyrus- merged commit 297b04b into dev Nov 5, 2024
2 checks passed
@cyrus- cyrus- deleted the remove_termbase_modules branch November 5, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants