-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try making all of the ids type parameters #1371
Draft
7h3kk1d
wants to merge
8
commits into
dev
Choose a base branch
from
pull_up_ids
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,046
−1,508
Draft
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3cb13b1
Make id a type param on tile
7h3kk1d a5a4957
pain and regret
7h3kk1d 2693f23
Fix tests
7h3kk1d b962426
Add id params to the other TermBase types
7h3kk1d 00005b1
Add annotated type
7h3kk1d ff86788
Sunk cost fallacy
7h3kk1d bc56c2f
Back to working
7h3kk1d 6d6f234
Fix tests
7h3kk1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
include Id.Map; | ||
type t = Id.Map.t(Tile.t); | ||
type t = Id.Map.t(Tile.t(Id.t)); | ||
|
||
// tail-recursive | ||
let rec mk = (~map=empty, seg: Segment.t): t => | ||
let rec mk = (~map=empty, seg: Segment.t(Id.t)): t => | ||
Segment.tiles(seg) | ||
|> List.fold_left( | ||
(map, t: Tile.t) => { | ||
(map, t: Tile.t(Id.t)) => { | ||
t.children | ||
|> List.fold_left((map, kid) => mk(~map, kid), add(t.id, t, map)) | ||
|> List.fold_left( | ||
(map, kid) => mk(~map, kid), | ||
add(t.extra, t, map), | ||
) | ||
}, | ||
map, | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,28 +13,28 @@ type kind = | |
| TextArea; | ||
|
||
[@deriving (show({with_path: false}), sexp, yojson)] | ||
type segment = list(piece) | ||
and piece = | ||
| Tile(tile) | ||
type segment('a) = list(piece('a)) | ||
and piece('a) = | ||
| Tile(tile('a)) | ||
| Grout(Grout.t) | ||
| Secondary(Secondary.t) | ||
| Projector(projector) | ||
and tile = { | ||
| Projector(projector('a)) | ||
and tile('a) = { | ||
// invariants: | ||
// - length(mold.in_) + 1 == length(label) | ||
// - length(shards) <= length(label) | ||
// - length(shards) == length(children) + 1 | ||
// - sort(shards) == shards | ||
id: Id.t, | ||
extra: 'a, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rename this to something more relevant and have the inhabitants use a |
||
label: Label.t, | ||
mold: Mold.t, | ||
shards: list(int), | ||
children: list(segment), | ||
children: list(segment('a)), | ||
} | ||
and projector = { | ||
id: Id.t, | ||
and projector('a) = { | ||
kind, | ||
syntax: piece, | ||
extra: 'a, | ||
syntax: piece('a), | ||
model: string, | ||
}; | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main idea for tiles.