Additional tests #1369
Merged
Additional tests #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7h3kk1d
commented
Aug 10, 2024
| @@ -3,7 +3,10 @@ open Junit_alcotest; | |||
| let (suite, _) = | |||
| run_and_report( | |||
| ~and_exit=false, | |||
| "Dynamics", | |||
| [("Elaboration", Test_Elaboration.elaboration_tests)], | |||
| "HazelTests", | |||
There was a problem hiding this comment.
It's still very unclear to me at what level this report is supposed to be built at. A lot of sample repos online just have the full suite or tests. The alcotest documentation lists a module but no clear way to have a bunch of modules in a report.
7h3kk1d
commented
Aug 10, 2024
test/haz3ltest.re
Outdated
Comment on lines
8
to
9
| ("Elaboration", Test_Elaboration.elaboration_tests), | ||
| Test_ListUtil.tests, |
There was a problem hiding this comment.
I prefer naming the tests in the test module but 🤷
7h3kk1d
commented
Aug 19, 2024
src/util/ListUtil.re
Outdated
Comment on lines
15
to
28
| /** | ||
| Groups elements of a list by a specified key. | ||
|
|
||
| {b Note: The groups are not guaranteed to preserve the order of elements from the original list. } | ||
|
|
||
| @param key | ||
| The key function used to determine the grouping key. | ||
|
|
||
| @param xs | ||
| The list of elements to be grouped. | ||
|
|
||
| @return | ||
| A list of tuples where each tuple contains the grouping key and a list of elements that belong to that group. | ||
| */ |
There was a problem hiding this comment.
Gearing up for a future odoc pr. Mostly added this so the ordering is noted.
7h3kk1d
commented
Aug 19, 2024
| `Quick, | ||
| () => { | ||
| let xs = [1, 2, 3, 2]; | ||
| check(list(int), "Unique list", [1, 3, 2], ListUtil.dedup(xs)); // TODO: Interesting the order here is messed up because of fold_right |
There was a problem hiding this comment.
I can add odoc comments for these if it's how we want to handle it
7h3kk1d
commented
Aug 19, 2024
cyrus-
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.