Use js_of_ocaml regex for split

hazelgrove · Dec 10, 2024 · befc42d · befc42d
1 parent 42a6262
commit befc42d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/util/StringUtil.re b/src/util/StringUtil.re
@@ -38,13 +38,7 @@ let split = Js_of_ocaml.Regexp.split;
 
 let plain_split: (string, string) => list(string) =
   (str, sep) => {
-    Js_of_ocaml.(
-      Js.string(str)##split(Js.string(sep))
-      |> Js.str_array
-      |> Js.to_array
-      |> Array.to_list
-      |> List.map(Js.to_string)
-    );
+    split(Js_of_ocaml.Regexp.regexp_string(sep), str);
   };
 
 let to_lines = String.split_on_char('\n');

diff --git a/test/Test_StringUtil.re b/test/Test_StringUtil.re
@@ -37,5 +37,13 @@ let tests = (
         StringUtil.plain_split("abbe", "b"),
       )
     }),
+    test_case("regexp special character in separator", `Quick, () => {
+      check(
+        list(string),
+        "split",
+        ["a", "c"],
+        StringUtil.plain_split("a.*c", ".*"),
+      )
+    }),
   ],
 );