Add ana and ana_action tests #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpoly1219 does this handle all of the rules from the paper? if not, can you create a progress checklist similar to hazelgrove/hazel#1197 with all of the rule names from the paper? |
…has major issues, I believe I know what they are but I will fix it next week hopefully
cyrus-
requested changes
Jan 13, 2025
test/Test_type_action.re
Outdated
| let given: option((Hazelnut.Zexp.t, Hazelnut.Htyp.t)) = | ||
| Hazelnut.syn_action(ctx, (ze, t), a); | ||
| let expected: option((Hazelnut.Zexp.t, Hazelnut.Htyp.t)) = | ||
| Some((RAsc(Lit(1), RArrow(Num,Cursor(Hole))), Arrow(Num,Hole))); |
There was a problem hiding this comment.
Should be fixed now. I wrapped the literal in a lambda expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Adds to #7.
I added
erase_expandsyntests on the last pull request that has been merged. That left me withana,syn_action, andana_actionto implement. Razeen Maroof and I decided to split the load into two, where I decided to implementanaandana_action.Changes:
anaandana_actiontests.ppx_deriving.showppx_deriving.showas dependency