-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friendly group name to display group names with spaces #326
Open
angcast
wants to merge
50
commits into
haystack:master
Choose a base branch
from
angcast:friendly-group-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for Django1.8
PR for Django1.10
angcast
changed the title
Created friendly group name
Friendly group name to display group names with spaces
Dec 10, 2020
Also, we might want to say in the interface that space is allowed?
|
soyapark
reviewed
Dec 10, 2020
.env.example
Outdated
GMAIL_PASSWORD=YOUR_APP_PASSWORD | ||
|
||
[email protected] | ||
GMAIL_PASSWORD=ivuhzrgjsmaiyefg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you retract this change? .env.example is meant to be a template
… the correct group name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a person tried to input a group name with spaces, it would not work. Now with this change, this is possible. If a person writes a name with spaces, the name attribute in the Group model will replace the spaces with underscores. Meanwhile, the friendly_name attribute will keep the spaces and use this to display the name with the spaces in the frontend.