Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-container to include short example for config #2886

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

jfwerner
Copy link

@jfwerner jfwerner commented Oct 14, 2024

Added a short example to explain what should actually be set as a OPENVPN_CONFIG variable.

Technical deep dive is great and interesting, but should come later. The most needed basic information to use the parameter should come first, further explanation should come afterwards.

Bit of background/explanation: I was so confused by what to put in the CONFIG variable that I messed around with a manual ovpn instead. Judging by #2408 I'm not the only one. I realize the same explanation as in the issue is present in this wiki page, but it's far down, and opening the github page is much quicker and easier imo. (If you're in the docs you already have a browser open, but one might configure the container through portainer instead of a terminal/ssh connection)

Breaking change

<placeholder>

Proposed change

<placeholder>

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this container)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: relates to #2408
  • Link to documentation updated (if done separately): https://...

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

Added a short example to explain what should actually be set as a OPENVPN_CONFIG variable. 

Technical deep dive is great and interesting, but should come later. The most needed basic information to use the parameter should come first, further explanation should come afterwards.

Bit of background/explanation: I was so confused by what to put in the CONFIG variable that I messed around with a manual ovpn instead. Judging by haugene#2408 I'm not the only one. I realize the same explanation as in the issue is present in this wiki page, but it's far down, and opening the github page is much quicker and easier imo. (If you're in the docs you already have a browser open, but one might configure the container through portainer instead of a terminal/ssh connection)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant