Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade @openzeppelin/contracts-upgradeable from 4.5.2 to 4.8.0 #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snyk-bot
Copy link

@snyk-bot snyk-bot commented Jan 6, 2023

Snyk has created this PR to upgrade @openzeppelin/contracts-upgradeable from 4.5.2 to 4.8.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 11 versions ahead of your current version.
  • The recommended version was released 2 months ago, on 2022-11-08.

The recommended version fixes:

Severity Issue PriorityScore (*) Exploit Maturity
Improper Verification of Cryptographic Signature
SNYK-JS-OPENZEPPELINCONTRACTSUPGRADEABLE-2980280
599/1000
Why? Has a fix available, CVSS 7.7
No Known Exploit
Incorrect Calculation
SNYK-JS-OPENZEPPELINCONTRACTSUPGRADEABLE-2964947
599/1000
Why? Has a fix available, CVSS 7.7
No Known Exploit
Information Exposure
SNYK-JS-OPENZEPPELINCONTRACTSUPGRADEABLE-2958049
599/1000
Why? Has a fix available, CVSS 7.7
No Known Exploit
Information Exposure
SNYK-JS-OPENZEPPELINCONTRACTSUPGRADEABLE-2958046
599/1000
Why? Has a fix available, CVSS 7.7
No Known Exploit
Denial of Service (DoS)
SNYK-JS-OPENZEPPELINCONTRACTSUPGRADEABLE-2965799
599/1000
Why? Has a fix available, CVSS 7.7
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Release notes
Package name: @openzeppelin/contracts-upgradeable
  • 4.8.0 - 2022-11-08

    Note
    Don't miss the section on Breaking changes at the end.

    • TimelockController: Added a new admin constructor parameter that is assigned the admin role instead of the deployer account. (#3722)
    • Initializable: add internal functions _getInitializedVersion and _isInitializing (#3598)
    • ERC165Checker: add supportsERC165InterfaceUnchecked for consulting individual interfaces without the full ERC165 protocol. (#3339)
    • Address: optimize functionCall by calling functionCallWithValue directly. (#3468)
    • Address: optimize functionCall functions by checking contract size only if there is no returned data. (#3469)
    • Governor: make the relay function payable, and add support for EOA payments. (#3730)
    • GovernorCompatibilityBravo: remove unused using statements. (#3506)
    • ERC20: optimize _transfer, _mint and _burn by using unchecked arithmetic when possible. (#3513)
    • ERC20Votes, ERC721Votes: optimize getPastVotes for looking up recent checkpoints. (#3673)
    • ERC20FlashMint: add an internal _flashFee function for overriding. (#3551)
    • ERC4626: use the same decimals() as the underlying asset by default (if available). (#3639)
    • ERC4626: add internal _initialConvertToShares and _initialConvertToAssets functions to customize empty vaults behavior. (#3639)
    • ERC721: optimize transfers by making approval clearing implicit instead of emitting an event. (#3481)
    • ERC721: optimize burn by making approval clearing implicit instead of emitting an event. (#3538)
    • ERC721: Fix balance accounting when a custom _beforeTokenTransfer hook results in a transfer of the token under consideration. (#3611)
    • ERC721: use unchecked arithmetic for balance updates. (#3524)
    • ERC721Consecutive: Implementation of EIP-2309 that allows batch minting of ERC721 tokens during construction. (#3311)
    • ReentrancyGuard: Reduce code size impact of the modifier by using internal functions. (#3515)
    • SafeCast: optimize downcasting of signed integers. (#3565)
    • ECDSA: Remove redundant check on the v value. (#3591)
    • VestingWallet: add releasable getters. (#3580)
    • VestingWallet: remove unused library Math.sol. (#3605)
    • VestingWallet: make constructor payable. (#3665)
    • Create2: optimize address computation by using assembly instead of abi.encodePacked. (#3600)
    • Clones: optimized the assembly to use only the scratch space during deployments, and optimized predictDeterministicAddress to use fewer operations. (#3640)
    • Checkpoints: Use procedural generation to support multiple key/value lengths. (#3589)
    • Checkpoints: Add new lookup mechanisms. (#3589)
    • Arrays: Add unsafeAccess functions that allow reading and writing to an element in a storage array bypassing Solidity's "out-of-bounds" check. (#3589)
    • Strings: optimize toString. (#3573)
    • Ownable2Step: extension of Ownable that makes the ownership transfers a two step process. (#3620)
    • Math and SignedMath: optimize function max by using > instead of >=. (#3679)
    • Math: Add log2, log10 and log256. (#3670)
    • Arbitrum: Update the vendored arbitrum contracts to match the nitro upgrade. (#3692)

    Breaking changes

    • ERC721: In order to add support for batch minting via ERC721Consecutive it was necessary to make a minor breaking change in the internal interface of ERC721. Namely, the hooks _beforeTokenTransfer and _afterTokenTransfer have one additional argument that may need to be added to overrides:
     function _beforeTokenTransfer(
         address from,
         address to,
         uint256 tokenId,
    +    uint256 batchSize
     ) internal virtual override
    • ERC4626: Conversion from shares to assets (and vice-versa) in an empty vault used to consider the possible mismatch between the underlying asset's and the vault's decimals. This initial conversion rate is now set to 1-to-1 irrespective of decimals, which are meant for usability purposes only. The vault now uses the assets decimals by default, so off-chain the numbers should appear the same. Developers overriding the vault decimals to a value that does not match the underlying asset may want to override the _initialConvertToShares and _initialConvertToAssets to replicate the previous behavior.

    • TimelockController: During deployment, the TimelockController used to grant the TIMELOCK_ADMIN_ROLE to the deployer and to the timelock itself. The deployer was then expected to renounce this role once configuration of the timelock is over. Failing to renounce that role allows the deployer to change the timelock permissions (but not to bypass the delay for any time-locked actions). The role is no longer given to the deployer by default. A new parameter admin can be set to a non-zero address to grant the admin role during construction (to the deployer or any other address). Just like previously, this admin role should be renounced after configuration. If this param is given address(0), the role is not allocated and doesn't need to be revoked. In any case, the timelock itself continues to have this role.

    Deprecations

    • EIP712: Added the file EIP712.sol and deprecated draft-EIP712.sol since the EIP is no longer a Draft. Developers are encouraged to update their imports. (#3621)
    -import "@ openzeppelin/contracts/utils/cryptography/draft-EIP712.sol";
    +import "@ openzeppelin/contracts/utils/cryptography/EIP712.sol";
    • ERC721Votes: Added the file ERC721Votes.sol and deprecated draft-ERC721Votes.sol since it no longer depends on a Draft EIP (EIP-712). Developers are encouraged to update their imports. (#3699)
    -import "@ openzeppelin/contracts/token/ERC721/extensions/draft-ERC721Votes.sol";
    +import "@ openzeppelin/contracts/token/ERC721/extensions/ERC721Votes.sol";

    ERC-721 Compatibility Note

    ERC-721 integrators that interpret contract state from events should make sure that they implement the clearing of approval that is implicit in every transfer according to the EIP. Previous versions of OpenZeppelin Contracts emitted an explicit Approval event even though it was not required by the specification, and this is no longer the case.

    With the new ERC721Consecutive extension, the internal workings of ERC721 are slightly changed. Custom extensions to ERC721 should be reviewed to ensure they remain correct. The internal functions that should be considered are _ownerOf (new), _beforeTokenTransfer, and _afterTokenTransfer.

  • 4.8.0-rc.2 - 2022-10-25

    v4.8.0-rc.2

  • 4.8.0-rc.1 - 2022-09-24

    v4.8.0-rc.1

  • 4.8.0-rc.0 - 2022-09-13

    v4.8.0-rc.0

  • 4.7.3 - 2022-08-10

    ⚠️ This is a patch for a medium severity issue. For more information visit the security advisory.

    Breaking changes

    • ECDSA: recover(bytes32,bytes) and tryRecover(bytes32,bytes) no longer accept compact signatures to prevent malleability. Compact signature support remains available using recover(bytes32,bytes32,bytes32) and tryRecover(bytes32,bytes32,bytes32).
  • 4.7.2 - 2022-07-27

    ⚠️ This is a patch for three issues, including a high severity issue in GovernorVotesQuorumFraction. For more information visit the security advisories (1, 2, 3).

    1. GovernorVotesQuorumFraction: Fixed quorum updates so they do not affect past proposals that failed due to lack of quorum. (#3561)
    2. ERC165Checker: Added protection against large returndata. (#3587)
    3. LibArbitrumL2, CrossChainEnabledArbitrumL2: Fixed detection of cross-chain calls for EOAs. Previously, calls from EOAs would be classified as cross-chain calls. (#3578)
  • 4.7.1 - 2022-07-20

    ⚠️ This is a patch for a medium severity issue affecting SignatureChecker and a high severity issue affecting ERC165Checker. For more information visit the security advisories (1, 2).

    • SignatureChecker: Fix an issue that causes isValidSignatureNow to revert when the target contract returns ill-encoded data. (#3552)
    • ERC165Checker: Fix an issue that causes supportsInterface to revert when the target contract returns ill-encoded data. (#3552)
  • 4.7.0 - 2022-06-30
    Read more
  • 4.7.0-rc.0 - 2022-06-10

    v4.7.0-rc.0

  • 4.6.0 - 2022-05-02
    Read more
  • 4.6.0-rc.0 - 2022-04-01
  • 4.5.2 - 2022-03-02
from @openzeppelin/contracts-upgradeable GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant