address review comments

hasura · Apr 30, 2024 · 7c09e64 · 7c09e64
1 parent 5a23da7
commit 7c09e64
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/changelog.md b/changelog.md
@@ -12,7 +12,7 @@
 
 - Initial release with support of ndc-spec v0.1.2 (beta)
   - Support for CLI plugin for Hasura v3 CLI, which allows the CLI to 
-    automatically introspect the database on demand.
+    introspect the database on demand.
   - Query explain endpoint has been changed from `/explain` to `/query/explain`.
   - The default port was changed from 8100 to 8080.
 

diff --git a/crates/cli/src/lib.rs b/crates/cli/src/lib.rs
@@ -205,7 +205,7 @@ async fn update_uri_from_context(context: &Context) -> anyhow::Result<()> {
             read_config_file_contents(&configuration_file_path).await?;
         serde_json::from_str(&configuration_file_contents)?
     };
-    if input == ndc_sqlserver::configuration::RawConfiguration::empty() {
+    if input.mssql_connection_string.is_empty() {
         if let Some(uri) = &context.uri {
             input.mssql_connection_string = uri.clone();
         } else {