Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facelift README #63

Merged
merged 2 commits into from
Jun 19, 2020
Merged

facelift README #63

merged 2 commits into from
Jun 19, 2020

Conversation

ulysses4ever
Copy link
Contributor

Mostly, remove extraneous spaces between [] and () in MD-style hyperlinks.

Copy link
Contributor

@curiousleo curiousleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this definitely makes the README nicer to look at.

I think the README will probably need an overhaul once #62 lands, but until then, I think this is an incremental improvement worth merging.

@lehins
Copy link
Contributor

lehins commented Jun 4, 2020

This is an improvement, so thank you @ulysses4ever but @curiousleo let's wait until #62 is merged into master.

README.md Outdated Show resolved Hide resolved
@Bodigrim
Copy link
Contributor

Bodigrim commented Jun 4, 2020

@lehins it should be trivial to rebase #62 atop of this, when it is ready to be merged. I feel important to merge such PRs, encouraging people to improve documentation.

@lehins
Copy link
Contributor

lehins commented Jun 4, 2020

@Bodigrim I literally just reset master to v1.1 tag today to avoid unnecessary rebasing, because there is a lot of commits and enormous amount of changes in #62. Let's just wait till next week, this is not a critical change. Moreover, the link still needs fixing

I'd appreciate if you could give #62 a review though, if you have time that is ;) That would be really helpful.

@ulysses4ever
Copy link
Contributor Author

@lehins the link should be fixed now.

@lehins lehins merged commit 8bfda8a into haskell:master Jun 19, 2020
curiousleo added a commit to curiousleo/random that referenced this pull request Jun 23, 2020
Includes changes from haskell#63.
curiousleo added a commit to curiousleo/random that referenced this pull request Jun 23, 2020
Includes changes from haskell#63.
curiousleo added a commit to idontgetoutmuch/random that referenced this pull request Jun 23, 2020
Includes changes from haskell#63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants