Release/v1.2.1.3 #169
Merged
Release/v1.2.1.3 #169
+214
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with `random-1.3.0` doctests are executed in a CI by invoking `doctest` executable directly, which turns out to be the correct way to use doctest. This was pointed out in #165 In order to avoid `random-1.2.x` major version depending on doctest, this patch removes doctest usage completely, in favor of a new setup going forward. However, in order to prevent tooling breakaage downstream that runs tests we do not remove the `doctest` executable section.
This is necessary to allow testing with lts-9 snapshot, since stack is still capable of installing ghc-8.0 and ghc-8.2, while ghcup is having issues in achieving that on CI
lehins
force-pushed
the
release/v1.2.1.3
branch
from
48aba57 to
13db6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @juhp's request in #165 (comment) prepping a patch release that removes doctest usage.
Correct usage of doctest have been implemented in #165 and #167