Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
I've been thinking for a while about this and I think the correct path forward is to introduce a separate class for splittable generators, which I called
SplitGen
and deprecate the oldsplit
function.The benefit of this approach is that current user code does not break and gives a graceful path to upgrade to the new type class.
Other approaches were considered in #94 and discussed at length in idontgetoutmuch#7
I highly doubt that we will provide a generic approach of using some hash function for implementing PRNG splitting. I would rather prefer such functionality be in a separate library that other packages that want to implement
SplitGen
can opt-in into using.