Skip to content
gracjan edited this page Apr 25, 2015 · 2 revisions

Steps to follow when merging a pull request

  1. Read the code in github interface, comment.

  2. Go through Pull request checklist mark each item as you go.

  3. Check out haskell/master (no local commits).

  4. Make sure you can reproduce the issue, error or missing functionality.

  5. Check out merged branch, like this:

    git fetch haskell pull/9999/merge:pr-9999
    git checkout pr-9999

    where 9999 is the pull request number and haskell is the origin of github.com/haskell/haskell-mode.

  6. See if functionality works as advertised.

  7. Check if TravisCI is green for this branch.

  8. Click the Merge branch green button.

Clone this wiki locally