Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run hooks for haskell-error-mode #1745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erickgnavar
Copy link

@erickgnavar erickgnavar commented Apr 24, 2021

When haskell-interactive-popup-error is called, haskell-error-mode
hooks aren't running because run-hooks call is missed

When haskell-interactive-popup-error is called, haskell-error-mode
hooks aren't running because run-hooks call is missed
@erickgnavar erickgnavar force-pushed the run-hooks-for-haskell-error-mode branch from 77440c3 to be8a7ff Compare April 24, 2021 17:17
@erickgnavar erickgnavar changed the title Run hooks for haskell-compilation-mode Run hooks for haskell-error-mode Apr 24, 2021
@purcell
Copy link
Member

purcell commented Apr 25, 2021

Isn't this because the hook variable name produced by the define-minor-mode form is haskell-error-mode-hook, without a trailing s?

@erickgnavar
Copy link
Author

Isn't this because the hook variable name produced by the define-minor-mode form is haskell-error-mode-hook, without a trailing s?

The code I'm adding is without the trailing s as you can see

(run-hooks 'haskell-error-mode-hook)

Maybe there was a confusion with the PR's description 🤔

@purcell
Copy link
Member

purcell commented Apr 25, 2021

Oh, sorry if I got confused. But in any case, the expanded definition of haskell-error-mode includes code to run that hook, so I'd like to understand why that didn't seem to be working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants