Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for sublibrary module listings #1279

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

414owen
Copy link
Contributor

@414owen 414owen commented Dec 30, 2023

works on #1218

Changes:

  • Adds a "renderer" for library names
  • Uses the library name renderer in the dependency details page
  • Add module and signature trees per-library on the package page

I figured it's appropriate to make sure libraries are shown by the same name in the dependency-details page, and on the package page, hence the library name renderer. I also think it's more intuitive to refer to the libraries by the same name that is used to add them as dependencies, rather than just saying library, or using just the sublibrary component name.

Screenshots

Using the unpacked-containers package, as it has sublibraries, and signatures as well as modules

Before

Screenshot from 2023-12-30 20-18-28
Screenshot from 2023-12-30 19-47-05

After

Screenshot from 2023-12-30 20-18-20

Screenshot from 2023-12-30 19-46-56

Copy link
Contributor

@gbaz gbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cleanly done, thanks!

@gbaz gbaz merged commit 9b8be6f into haskell:master Dec 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants