merge queue: embarking 3.10 (36a7f2f) and #9125 together #9127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The password-command option does not parse its value correctly. Quotes are ignored, making many kinds of commands impossible to express (e.g. `sh -c "foo | bar"`). Also, `cabal user-config` treats the argument list as a *list of option values*, rather than a *value that is a list*. As a consequence, `cabal user-config update` corrupts the value in the config file. Fix these issues by parsing the command as a space separated list of tokens, and changing the getter to `unwords` the value and return a *singleton* list. Also update the argument placeholder from `PASSWORD` to `COMMAND`. Fixes: #6268 (cherry picked from commit 95f48ad) # Conflicts: # cabal-install/src/Distribution/Client/Setup.hs # cabal-install/src/Distribution/Deprecated/ParseUtils.hs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged. 🎉
Branch 3.10 (36a7f2f) and #9125 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #9125.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by>=1[🛡 GitHub branch protection]#changes-requested-reviews-by=0[🛡 GitHub branch protection]check-success=Doctest Cabalcheck-neutral=Doctest Cabalcheck-skipped=Doctest Cabalcheck-success=Meta checkscheck-neutral=Meta checkscheck-skipped=Meta checkscheck-success=Validate post jobcheck-neutral=Validate post jobcheck-skipped=Validate post jobcheck-success=docs/readthedocs.org:cabalcheck-neutral=docs/readthedocs.org:cabalcheck-skipped=docs/readthedocs.org:cabalcheck-success=Bootstrap ubuntu-latest ghc-8.10.7check-neutral=Bootstrap ubuntu-latest ghc-8.10.7check-skipped=Bootstrap ubuntu-latest ghc-8.10.7check-success=Bootstrap ubuntu-latest ghc-9.0.2check-neutral=Bootstrap ubuntu-latest ghc-9.0.2check-skipped=Bootstrap ubuntu-latest ghc-9.0.2Visit the Mergify Dashboard to check the state of the queue
default.More information about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com