Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of password-command option (#6268) #9002

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Fix parsing of password-command option (#6268) #9002

merged 1 commit into from
Jun 18, 2023

Commits on Jun 12, 2023

  1. Fix parsing of password-command option (haskell#6268) 

    The password-command option does not parse its value correctly.
Quotes are ignored, making many kinds of commands impossible to
express (e.g.  `sh -c "foo | bar"`).  Also, `cabal user-config`
treats the argument list as a *list of option values*, rather than a
*value that is a list*.  As a consequence, `cabal user-config
update` corrupts the value in the config file.

Fix these issues by parsing the command as a space separated list of
tokens, and changing the getter to `unwords` the value and return a
*singleton* list.  Also update the argument placeholder from
`PASSWORD` to `COMMAND`.

Fixes: haskell#6268
    @frasertweedale
    frasertweedale committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    95f48ad View commit details
    Browse the repository at this point in the history