Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid incomplete record selection warning #10403

Merged
merged 1 commit into from
Oct 3, 2024
Merged

avoid incomplete record selection warning #10403

merged 1 commit into from
Oct 3, 2024

Conversation

geekosaur
Copy link
Collaborator

Per SPJ suggection.

Closes: #10402

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). (doesn't fix CI but GHC HQ will want a 3.14 backport at minimum)

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 1, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Oct 1, 2024
@mergify mergify bot merged commit 1e5bfa1 into haskell:master Oct 3, 2024
48 checks passed
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@geekosaur
Copy link
Collaborator Author

@mergify backport 3.14

@mergify mergify bot mentioned this pull request Oct 12, 2024
Merged
2 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport 3.14

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 12, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Oct 12, 2024
@mergify
Merge pull request #10449 from haskell/mergify/bp/3.12/pr-10403
28f021d 
avoid incomplete record selection warning (backport #10403)
mergify bot added a commit that referenced this pull request Nov 7, 2024
@mergify
Merge pull request #10450 from haskell/mergify/bp/3.14/pr-10403
c7abe0a 
avoid incomplete record selection warning (backport #10403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kleidukos Kleidukos Kleidukos approved these changes

@alt-romes alt-romes alt-romes approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor to avoid incomplete record selection warning
3 participants
@geekosaur @alt-romes @Kleidukos