haddock-project: add CommonSetupFlags
#10393
Conversation
9999years
force-pushed
the
wiggles/haddock-project-parse-common-flags
branch
from
f2afeea
to
89cb6a8
Compare
9999years
changed the title
haddock-project: add CommonFlagshaddock-project: add CommonSetupFlags
9999years
force-pushed
the
wiggles/haddock-project-parse-common-flags
branch
from
89cb6a8
to
7fa0e5e
Compare
9999years
force-pushed
the
wiggles/haddock-project-parse-common-flags
branch
from
7fa0e5e
to
14510a9
Compare
| @@ -1408,7 +1408,8 @@ legacySharedConfigFieldDescrs constraintSrc = | |||
| configPackageDBs | |||
| (\v conf -> conf{configPackageDBs = v}) | |||
| ] | |||
| . filterFields (["verbose", "builddir"] ++ map optionName installDirsOptions) | |||
| . aliasField "keep-temp-files" "haddock-keep-temp-files" | |||
There was a problem hiding this comment.
What is this line doing?
There was a problem hiding this comment.
Oh, this line shouldn't be here. It's so that when the cabal.project parser sees haddock-keep-temp-files, it uses the new keep-temp-files field, but I don't actually add that until #10292.
| @@ -457,7 +458,8 @@ data HaddockProjectFlags = HaddockProjectFlags | |||
| defaultHaddockProjectFlags :: HaddockProjectFlags | |||
There was a problem hiding this comment.
Why are haddock-project options defined in Cabal library at all.. I understand nothing to do with you but it's a cabal-install command.
|
I am not sure this is the right direction of travel -- why are we propagating the design flaw of reusing the options parsers for the |
9999years
force-pushed
the
wiggles/haddock-project-parse-common-flags
branch
from
14510a9
to
5730083
Compare
I can't comment on the design here, but all the other |
Split off of #10292. This lets
cabal haddock-projectuse the standardCommonFlagsthat other commands use to set verbosity and so on.