Fix Unicode output in cabal-testsuite
#10387
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Process.createPipe
calls (through many intermediaries)GHC.IO.Handle.FD.fdToHandle
, whose documentation says:The documentation for
System.IO.hSetBinaryMode
says:But this is a lie, and Unicode written to or read from binary handles is always encoded or decoded as Latin-1, which is always the wrong choice.
Therefore, we explicitly set the output to UTF-8 to keep it consistent between platforms and correct on all modern computers.
See: https://gitlab.haskell.org/ghc/ghc/-/issues/25307