Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create temp files in temp directory #10366

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Create temp files in temp directory #10366

merged 1 commit into from
Oct 4, 2024

Commits on Oct 3, 2024

  1. Create temp files in temp directory 

    This change ensures all temporal files are created in the system temp directory
which usually is in a short path. This helps with Windows not being capable of
creating temp files in long directories, like the ones that result from
Backpack.

See how GetTempFileNameW specifies:

> The string cannot be longer than `MAX_PATH–14` characters or `GetTempFileName`
will fail.

And actually there is a TODO in `Win32Utils.c` in GHC:

https://gitlab.haskell.org/ghc/ghc/-/blob/3939a8bf93e27d8151aa1d92bf3ce10bbbc96a72/libraries/ghc-internal/cbits/Win32Utils.c#L259

Closes haskell#10191.
    @jasagredo @Mikolaj
    jasagredo authored and Mikolaj committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8161f5f View commit details
    Browse the repository at this point in the history