-
Notifications
You must be signed in to change notification settings - Fork 697
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Let's see if the runner has stabilized yet. Also, fixed the arch issues (validate no longer assumes everything is x86_64). (cherry picked from commit f66eb28) # Conflicts: # .github/workflows/validate.yml
- Loading branch information
1 parent
a633f26
commit 875c616
Showing
1 changed file
with
90 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,7 +76,14 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
matrix: | ||
<<<<<<< HEAD | ||
os: [ubuntu-latest, macos-13, windows-latest] | ||
======= | ||
sys: | ||
- { os: windows-latest, shell: "C:/msys64/usr/bin/bash.exe -e {0}" } | ||
- { os: ubuntu-latest, shell: bash } | ||
- { os: macos-latest, shell: bash } | ||
>>>>>>> f66eb28e0 (try Apple AArch64 again) | ||
# If you remove something from here, then add it to the old-ghcs job. | ||
# Also a removed GHC from here means that we are actually dropping | ||
# support, so the PR *must* have a changelog entry. | ||
|
@@ -90,12 +97,34 @@ jobs: | |
- os: windows-latest | ||
ghc: '8.10.7' | ||
# lot of segfaults caused by ghc bugs | ||
<<<<<<< HEAD | ||
- os: windows-latest | ||
ghc: '8.8.4' | ||
# it often randomly does "C:\Users\RUNNER~1\AppData\Local\Temp\ghcFEDE.c: DeleteFile "\\\\?\\C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\ghcFEDE.c": permission denied (Access is denied.)" | ||
- os: windows-latest | ||
ghc: '8.6.5' | ||
|
||
======= | ||
- sys: | ||
{ os: windows-latest, shell: "C:/msys64/usr/bin/bash.exe -e {0}" } | ||
ghc: "8.8.4" | ||
# ghc before 8.10.5 doesn't run on AArch64 | ||
# 9.0.2 suffers from https://gitlab.haskell.org/ghc/ghc/-/issues/20592 | ||
# 8.10.7 throws asm errors in hashable's cbits suggesting the runner doesn't | ||
# support a CPU extension for hardware SHA; may be fixable with flags | ||
- sys: | ||
{ os: macos-latest, shell: bash } | ||
ghc: "9.0.2" | ||
- sys: | ||
{ os: macos-latest, shell: bash } | ||
ghc: "8.10.7" | ||
- sys: | ||
{ os: macos-latest, shell: bash } | ||
ghc: "8.8.4" | ||
defaults: | ||
run: | ||
shell: ${{ matrix.sys.shell }} | ||
>>>>>>> f66eb28e0 (try Apple AArch64 again) | ||
steps: | ||
|
||
- name: Work around XDG directories existence (haskell-actions/setup#62) | ||
|
@@ -172,6 +201,16 @@ jobs: | |
- name: Validate build | ||
run: sh validate.sh $FLAGS -s build | ||
|
||
- name: Canonicalize architecture | ||
run: | | ||
case ${{ runner.arch }} in | ||
X86) arch=i386 ;; | ||
X64) arch=x86_64 ;; | ||
ARM64) arch=aarch64 ;; | ||
*) echo "Unsupported architecture, please fix validate.yaml" 2>/dev/null; exit 1 ;; | ||
esac | ||
echo "CABAL_ARCH=$arch" >> "$GITHUB_ENV" | ||
- name: Tar cabal head executable | ||
if: matrix.ghc == env.GHC_FOR_RELEASE | ||
run: | | ||
|
@@ -190,7 +229,7 @@ jobs: | |
fi | ||
DIR=$(dirname "$CABAL_EXEC") | ||
FILE=$(basename "$CABAL_EXEC") | ||
CABAL_EXEC_TAR="cabal-head-${{ runner.os }}-x86_64.tar.gz" | ||
CABAL_EXEC_TAR="cabal-head-${{ runner.os }}-$CABAL_ARCH.tar.gz" | ||
tar -czvf "$CABAL_EXEC_TAR" -C "$DIR" "$FILE" | ||
echo "CABAL_EXEC_TAR=$CABAL_EXEC_TAR" >> "$GITHUB_ENV" | ||
|
@@ -201,7 +240,7 @@ jobs: | |
if: matrix.ghc == env.GHC_FOR_RELEASE | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: cabal-${{ runner.os }}-x86_64 | ||
name: cabal-${{ runner.os }}-${{ env.CABAL_ARCH }} | ||
path: ${{ env.CABAL_EXEC_TAR }} | ||
|
||
- name: Validate lib-tests | ||
|
@@ -356,18 +395,36 @@ jobs: | |
# This one uses the cabal HEAD generated executable in the previous step | ||
# to build itself again, as sanity check | ||
dogfooding: | ||
name: Dogfooding ${{ matrix.os }} ghc-${{ matrix.ghc }} | ||
runs-on: ${{ matrix.os }} | ||
name: Dogfooding ${{ matrix.sys.os }} ghc-${{ matrix.ghc }} | ||
runs-on: ${{ matrix.sys.os }} | ||
needs: validate | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, macos-13, windows-latest] | ||
sys: | ||
- { os: windows-latest, shell: "C:/msys64/usr/bin/bash.exe -e {0}" } | ||
- { os: ubuntu-latest, shell: bash } | ||
- { os: macos-latest, shell: bash } | ||
# We only use one ghc version the used one for the next release (defined at top of the workflow) | ||
# We need to build an array dynamically to inject the appropiate env var in a previous job, | ||
# see https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson | ||
ghc: ${{ fromJSON (needs.validate.outputs.GHC_FOR_RELEASE) }} | ||
|
||
defaults: | ||
run: | ||
shell: ${{ matrix.sys.shell }} | ||
|
||
steps: | ||
# TODO: make a reusable action for this | ||
- name: Canonicalize architecture | ||
run: | | ||
case ${{ runner.arch }} in | ||
X86) arch=i386 ;; | ||
X64) arch=x86_64 ;; | ||
ARM64) arch=aarch64 ;; | ||
*) echo "Unsupported architecture" 2>/dev/null; exit 1 ;; | ||
esac | ||
echo "CABAL_ARCH=$arch" >> "$GITHUB_ENV" | ||
- name: Work around XDG directories existence (haskell-actions/setup#62) | ||
if: runner.os == 'macOS' | ||
run: | | ||
|
@@ -385,11 +442,11 @@ jobs: | |
- name: Download cabal executable from workflow artifacts | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: cabal-${{ runner.os }}-x86_64 | ||
name: cabal-${{ runner.os }}-${{ env.CABAL_ARCH }} | ||
path: cabal-head | ||
|
||
- name: Untar the cabal executable | ||
run: tar -xzf "./cabal-head/cabal-head-${{ runner.os }}-x86_64.tar.gz" -C cabal-head | ||
run: tar -xzf "./cabal-head/cabal-head-${{ runner.os }}-$CABAL_ARCH.tar.gz" -C cabal-head | ||
|
||
- name: print-config using cabal HEAD | ||
run: sh validate.sh ${{ env.COMMON_FLAGS }} --with-cabal ./cabal-head/cabal -s print-config | ||
|
@@ -408,9 +465,16 @@ jobs: | |
needs: [validate, validate-old-ghcs, build-alpine, dogfooding] | ||
|
||
steps: | ||
<<<<<<< HEAD | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: cabal-Windows-x86_64 | ||
======= | ||
# for now this is hardcoded. is there a better way? | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: cabal-Windows-x86_64 | ||
>>>>>>> f66eb28e0 (try Apple AArch64 again) | ||
|
||
- uses: actions/download-artifact@v4 | ||
with: | ||
|
@@ -420,6 +484,7 @@ jobs: | |
with: | ||
name: cabal-Linux-static-x86_64 | ||
|
||
<<<<<<< HEAD | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: cabal-macOS-x86_64 | ||
|
@@ -436,6 +501,24 @@ jobs: | |
cabal-head-Linux-x86_64.tar.gz | ||
cabal-head-Linux-static-x86_64.tar.gz | ||
cabal-head-macOS-x86_64.tar.gz | ||
======= | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: cabal-macOS-aarch64 | ||
|
||
- name: Create GitHub prerelease | ||
uses: marvinpinto/[email protected] | ||
with: | ||
repo_token: ${{ secrets.GITHUB_TOKEN }} | ||
automatic_release_tag: cabal-head | ||
prerelease: true | ||
title: cabal-head | ||
files: | | ||
cabal-head-Windows-x86_64.tar.gz | ||
cabal-head-Linux-x86_64.tar.gz | ||
cabal-head-Linux-static-x86_64.tar.gz | ||
cabal-head-macOS-aarch64.tar.gz | ||
>>>>>>> f66eb28e0 (try Apple AArch64 again) | ||
|
||
prerelease-lts: | ||
name: Create a GitHub LTS prerelease with the binary artifacts | ||
|