-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(don't merge) Re-add siphash #222
Draft
jappeace
wants to merge
4
commits into
haskell-unordered-containers:master
Choose a base branch
from
jappeace:revert_disable_siphash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
(don't merge) Re-add siphash #222
jappeace
wants to merge
4
commits into
haskell-unordered-containers:master
from
jappeace:revert_disable_siphash
Commits on Oct 6, 2021
-
This reverts commit d65f9de. Re-add fnv Make it sortoff work with siphash except linking Make it link Remove typedef Add siphash.h to includes folder Fix golden test for siphash If we can't make siphash as fast as fnv, we probably want to support both in a final version. But I'll do that later. Fix tests for chuncks in bytestring (I just forgot to port a bunch of code) Fix lazy text test suite as well Delete example file Rebase on master, make test suite pass once more
Configuration menu - View commit details
-
Copy full SHA for e656df8 - Browse repository at this point
Copy the full SHA e656df8View commit details -
Address review comments, add more tests, fixup siphash
this is just the old implementation of siphash. with some tweaks to make it more streamable (still not great but good enough for benchmarks). -- squash log Use capi if available for offset Add more capi calls Flip expectation and actual args it showed up wrongly in the test suite Add more capi, add TODO Revert Hashable/Class to upstream master trying to contain changes to just that module Fix regression (once more) Don't expose the old functions Fix capi issues. Apprantly half of these functions weren't defined in the header. Tell people to use sse instead of asking Apply clang format Add siphash to benchmarks Add initializeState function, this will capture initizlie don't know how to do finalize yet Make it compile again (apparntly k1 and salt were used interchanbly) that's not a good idea Clean out the c code a bit. It was really strange. Make it build.. again? re-add header file I guess this will just keep on bein inconsistent remove cbits *.h from benchamark cabal file OMG that worked, lazy text now bytearray man, I doubted myself every step along the way, maybe I can do this? Draft for doing bytestring Make some headway on the regession tests Make testsuite pass once more Put in rounds as an argument Add compression round as args Add some common sense tests on previous state fails of course, not sure what's happening here Import <$> I guess different chars can also produce same hashes. Cleanup C-api for a bit it's still utterly broken however. I guess I need to try it out in C and see why the state isn't changing. Chunck -> Chunk Get rid of more c code idk maybe this do something with the sse stuff (after reading ghci comment) Figured out why no compression (lol) Update 64bit text once more Better explain 0 Split lines Lazy text can be big as well don't funroll by hand, add comments explaing what's going on Use properties instead of hardcoded test cases for statefullness Add prefix based tests as well hmm not so ez for text this also makes me doubt the bytestring implementaiton. I should check if with larger arbitrary instances that doesn't fall over (text tends to have larger bytestring representations then bytestring) Guess we really did solve the bytestring implementation This should pass CI Fix imports Fix ci for ghc 8.2.2 Add icescream cone Try fix ancient ghc Attempt fix ancient ghc II expose bytestring dependency ancient ghc import pure as well diddn't realize my style was so modern fix parse error maybe this will make conditional true? Fix properties for ancient ghc Fix parse error on imports add bytestring builder everywhere maybe solve cabal pain like this? disable property for ancient ghc try fix ancient ghc IX
Configuration menu - View commit details
-
Copy full SHA for b169fe9 - Browse repository at this point
Copy the full SHA b169fe9View commit details
Commits on Oct 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7fa43c2 - Browse repository at this point
Copy the full SHA 7fa43c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2397260 - Browse repository at this point
Copy the full SHA 2397260View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.