WIP: Remote store #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will also add |
|
Thanks! @imalsogreg are you able to give this a first-pass review? |
add missing Util
use ExceptT, concat logs, utility log functions
drop ExceptT todo
imalsogreg
approved these changes
Aug 4, 2018
| , network | ||
| , mtl | ||
| , cryptonite | ||
| , unordered-containers |
There was a problem hiding this comment.
The Ord a => Ord (HashSet a) instance that you use later requires unordered-containers >= 0.2.9
Ericson2314
pushed a commit
to obsidiansystems/hnix-store
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype of remote store access via worker protocol. Most of the API is implemented, tho I'm struggling a bit with path hash computation/extraction. Few methods are still left undefined as they require some special care.
I'm not quite sure how to fit this onto API in
System.Nix.Storeas well as it differentiates betweenrootedPathandvalidPath- not sure how are these related toPathandValidPathInfo(alsoValidPathInfoneeds separate file due to clashing record field names).Related to #12 and haskell-nix/hnix#173