Add more strictness to datatypes. #6
Conversation
|
It looks like using force here eliminates the need for this PR. Am I wrong? |
|
I yes, we don't need this commit in order to solve the issue. However this change may be in spirit of the |
1 similar comment
|
I yes, we don't need this commit in order to solve the issue. However this change may be in spirit of the |
|
@facundominguez what to do with this PR, close as it's not required for the current use? |
|
@facundominguez please take another look, this patch could be used instead of forcing in haskell-distributed/distributed-process#200 |
| @@ -293,7 +296,7 @@ getStaticLabel :: Get StaticLabel | |||
| getStaticLabel = do | |||
| header <- getWord8 | |||
| case header of | |||
| 0 -> StaticLabel <$> get | |||
| 0 -> mkStaticLabel <$> get | |||
There was a problem hiding this comment.
No need to force here.
|
Fixed both |
|
I don't see any changes. |
|
Is it better now? |
|
Merged as 953fbde. |
No description provided.