Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate tarpc to v0.34.0 #5417

Closed
wants to merge 1 commit into from
Closed

Conversation

hash-worker[bot]
Copy link
Contributor

@hash-worker hash-worker bot commented Oct 19, 2024

This PR contains the following updates:

Package Type Update Change
tarpc workspace.dependencies minor =0.33 -> =0.34.0

Release Notes

google/tarpc (tarpc)

v0.34.0

Breaking Changes
  • #[tarpc::server] is no more! Service traits now use async fns.
  • Channel::execute no longer spawns request handlers. Async-fn-in-traits makes it impossible to
    add a Send bound to the future returned by Serve::serve. Instead, Channel::execute returns a
    stream of futures, where each future is a request handler. To achieve the former behavior:
    channel.execute(server.serve())
           .for_each(|rpc| { tokio::spawn(rpc); })
New Features
  • Request hooks are added to the serve trait, so that it's easy to hook in cross-cutting
    functionality like throttling, authorization, etc.
  • The Client trait is back! This makes it possible to hook in generic client functionality like load
    balancing, retries, etc.

Configuration

📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@hash-worker hash-worker bot enabled auto-merge October 19, 2024 17:39
@hash-worker hash-worker bot requested a review from a team October 19, 2024 17:39
@github-actions github-actions bot added the area/deps Relates to third-party dependencies (area) label Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.22%. Comparing base (a4abfe0) to head (70221f0).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5417      +/-   ##
==========================================
+ Coverage   20.21%   20.22%   +0.01%     
==========================================
  Files         508      508              
  Lines       17252    17257       +5     
  Branches     2537     2537              
==========================================
+ Hits         3487     3490       +3     
- Misses      13727    13729       +2     
  Partials       38       38              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.39% <ø> (ø)
apps.hash-api 1.19% <ø> (ø)
blockprotocol.type-system 48.46% <ø> (ø)
local.hash-backend-utils 8.81% <ø> (ø)
local.hash-isomorphic-utils 1.06% <ø> (ø)
local.hash-subgraph 24.32% <ø> (ø)
rust.deer 5.88% <ø> (ø)
rust.error-stack 73.06% <ø> (-0.03%) ⬇️
rust.sarif 87.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimDiekmann
Copy link
Member

Cannot upgrade until google/tarpc#421 is solved (we need the Send bound which is not possible when using async fn in the trait declarations.

auto-merge was automatically disabled October 24, 2024 00:41

Pull request was closed

@hash-worker
Copy link
Contributor Author

hash-worker bot commented Oct 24, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (=0.34.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@hash-worker hash-worker bot deleted the deps/rs/tarpc-0.x branch October 24, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area)
Development

Successfully merging this pull request may close these issues.

2 participants