-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-3422: harpc
: rework the family of Codec
traits
#5362
Changes from 11 commits
00abe95
ab83fde
c0c6079
28177e3
27da6a8
a71bceb
cb55b0c
cf3a2b4
fcd0dee
2f36fe5
0a545dd
724abfa
d14f48a
7ba60e5
96d959c
eabf6aa
f0affc6
c8e5f8c
93cc669
f40a029
9f0051e
bbf8a09
522059f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ members = [ | |
"libs/@local/harpc/tower", | ||
"libs/@local/harpc/service", | ||
"libs/@local/harpc/server", | ||
"libs/@local/harpc/codec", | ||
"libs/@local/hql/*", | ||
"libs/antsi", | ||
"libs/deer", | ||
|
@@ -59,6 +60,7 @@ harpc-types.path = "libs/@local/harpc/types" | |
harpc-wire-protocol.path = "libs/@local/harpc/wire-protocol" | ||
harpc-tower.path = "libs/@local/harpc/tower" | ||
harpc-service.path = "libs/@local/harpc/service" | ||
harpc-codec.path = "libs/@local/harpc/codec" | ||
hash-graph-store.path = "apps/hash-graph/libs/store" | ||
hash-status.path = "libs/@local/status/rust" | ||
hash-tracing.path = "libs/@local/tracing" | ||
|
@@ -142,10 +144,8 @@ async-scoped = { version = "=0.9.0", default-features = false } | |
async-trait = { version = "=0.1.83", default-features = false } | ||
aws-config = { version = "=1.5.8" } | ||
aws-sdk-s3 = { version = "=1.54.0", default-features = false } | ||
base64 = { version = "=0.22.1", default-features = false } | ||
bitvec = { version = "=1.0.1", default-features = false } | ||
bytes-utils = { version = "=0.1.4", default-features = false } | ||
chrono = { version = "=0.4.38", default-features = false } | ||
clap = { version = "=4.5.20", features = ["std", "color", "help", "usage", "error-context", "suggestions"] } | ||
clap_complete = { version = "=4.5.33", default-features = false } | ||
coverage-helper = { version = "=0.2.2", default-features = false } | ||
|
@@ -155,7 +155,6 @@ dotenv-flow = { version = "=0.16.2", default-features = false } | |
expect-test = { version = "=1.5.0", default-features = false } | ||
futures = { version = "=0.3.31", default-features = false } | ||
hifijson = { version = "=0.2.2", default-features = false } | ||
http-body-util = { version = "=0.1.2", default-features = false } | ||
humansize = { version = "=2.1.3", default-features = false } | ||
hyper = { version = "=1.4.1", default-features = false } | ||
include_dir = { version = "=0.7.4", default-features = false } | ||
|
@@ -188,19 +187,13 @@ rustc_version = { version = "=0.4.1", default-features = false } | |
scc = { version = "=2.2.0", default-features = false } | ||
sentry = { version = "=0.34.0", default-features = false, features = ["backtrace", "contexts", "debug-images", "panic", "reqwest", "rustls", "tracing", "tower-http"] } | ||
seq-macro = { version = "=0.3.5", default-features = false } | ||
serde-value = { version = "=0.7.0", default-features = false } | ||
serde_plain = { version = "=1.0.2", default-features = false } | ||
serde_with = { version = "=3.11.0", default-features = false } | ||
similar-asserts = { version = "=1.6.0", default-features = false } | ||
spin = { version = "=0.9", default-features = false } | ||
supports-color = { version = "=3.0.1", default-features = false } | ||
supports-unicode = { version = "=3.0.0", default-features = false } | ||
sval = { version = "=2.13.1", default-features = false } | ||
syn = { version = "=2.0.79", default-features = false } | ||
tachyonix = { version = "=0.3.1", default-features = false } | ||
tarpc = { version = "=0.33", default-features = false } | ||
temporal-io-client = { git = "https://github.com/temporalio/sdk-core", rev = "7e3c23f" } | ||
temporal-io-sdk-core-protos = { git = "https://github.com/temporalio/sdk-core", rev = "7e3c23f" } | ||
Comment on lines
-202
to
-203
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are used but not as workspace dependency. Could you instead adjust There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see c8e5f8c |
||
test-fuzz = { version = "=6.0.0", default-features = false } | ||
test-log = { version = "=0.2.16", default-features = false } | ||
test-strategy = { version = "=0.4.0", default-features = false } | ||
|
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,38 @@ | ||||||||
cargo-features = ["edition2024"] | ||||||||
|
||||||||
[package] | ||||||||
name = "harpc-codec" | ||||||||
authors.workspace = true | ||||||||
version.workspace = true | ||||||||
edition.workspace = true | ||||||||
license.workspace = true | ||||||||
publish.workspace = true | ||||||||
|
||||||||
[dependencies] | ||||||||
error-stack = { workspace = true, public = true, features = ["serde"] } | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see: 96d959c |
||||||||
|
||||||||
# Public third-party dependencies | ||||||||
bytes = { workspace = true, public = true } | ||||||||
futures-core = { workspace = true, public = true } | ||||||||
serde = { workspace = true, public = true } | ||||||||
|
||||||||
# Private workspace dependencies | ||||||||
proptest = { workspace = true, optional = true } | ||||||||
test-strategy = { workspace = true, optional = true } | ||||||||
futures-util = { workspace = true, optional = true } | ||||||||
serde_json = { workspace = true, optional = true, public = true } | ||||||||
pin-project-lite = { workspace = true, optional = true } | ||||||||
memchr = { workspace = true, optional = true } | ||||||||
|
||||||||
# Private third-party dependencies | ||||||||
|
||||||||
[dev-dependencies] | ||||||||
tokio = { workspace = true, features = ["macros", "rt-multi-thread"] } | ||||||||
|
||||||||
[lints] | ||||||||
workspace = true | ||||||||
|
||||||||
[features] | ||||||||
proptest = ["dep:proptest", "dep:test-strategy"] | ||||||||
json = ["dep:serde_json", "dep:pin-project-lite", "dep:futures-util", "dep:memchr"] | ||||||||
serde = ["serde/derive"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spin is used in
error-stack
but with a>=0.9
bound. Probably good to remove it, yes.