Update DB Static role rotation logic to generate new password if retried password fails #28989
+101
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
vinay-gopalan
commented
Nov 21, 2024
| @@ -456,6 +458,7 @@ func (b *databaseBackend) setStaticAccount(ctx context.Context, s logical.Storag | |||
| Statements: statements, | |||
| } | |||
| input.Role.StaticAccount.PrivateKey = wal.NewPrivateKey | |||
| usedExistingCredential = true | |||
There was a problem hiding this comment.
Should we also generate a new Private Key credential if one fails? Or should the fix be focussed to password specific?
|
CI Results: |
kpcraig
reviewed
Nov 23, 2024
| @@ -1087,6 +1087,91 @@ func TestBackend_StaticRole_Role_name_check(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // TestStaticRole_NewCredentialGeneration verifies that new | |||
There was a problem hiding this comment.
I love when new tests appear =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when a static role rotation failed, we would store the password in the WAL entry. Upon retries, this same stored password would be reused. This leads customers to infinite loop cases where a failing password is infinitely retried.
This PR adds a fix which will generate a new credential and delete the existing WAL entry if it has failed on a retry. This will unblock customers until we can provide them with more control over their password policies so that password rotation failures don't happen as often.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.