Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the requirement of a single chain of issuance from verification #28925

Draft
wants to merge 2 commits into
base: victorr/vault-22013-pki-verify-certificates
Choose a base branch
from

Conversation

kitography
Copy link
Contributor

Description

Removes the requirement of a single chain of issuance from verification

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@kitography kitography added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 15, 2024
@kitography kitography added this to the 1.19.0-rc milestone Nov 15, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 15, 2024
@kitography kitography changed the base branch from main to victorr/vault-22013-pki-verify-certificates November 15, 2024 17:53
Copy link

CI Results: failed ❌
Failures:

Test Type Package Test Logs
standard builtin/logical/pkiext/pkiext_binary Test_ACME view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/acme_ip_sans view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/acme_prevents_ica view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/acme_wildcard view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/caddy_http view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/caddy_http_eab view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/caddy_tls-alpn view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/certbot view test results
standard builtin/logical/pkiext/pkiext_binary Test_ACME/group/certbot_eab view test results

and 14 - 10 other tests

@victorr victorr force-pushed the victorr/vault-22013-pki-verify-certificates branch 4 times, most recently from 2afbf98 to 19b3f66 Compare November 15, 2024 20:44
@victorr victorr force-pushed the victorr/vault-22013-pki-verify-certificates branch from 19b3f66 to 4f833b1 Compare November 25, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants