Fix duration response types #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix duration return types
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
Read and agreed to the CLA with both linked contributor accounts, but it still seems to hang around :O |
|
Thanks for submitting this fix, @JaniAnttonen. I'm blocked by this, so I'll use your commit for now until this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that recently the return types of duration fields like token ttl have been changed in Hashicorp Vault. I was running tests against Vault
v1.13.0and encountered this error. Updated tov1.16.1and the issue was still present.After a while I noticed that others had encountered this too and described the error in detail, linking to a change inside Vault: hashicorp/vault#25510 (Don't know what this actually fixed, seems more likely that it created this issue)
Resolves #257
Resolves #249
How has this been tested?
I've used my fork in a private project in tests and these updates fixed the issue. The tests are running dockerized versions of Hashicorp Vault using testcontainers, and the issue is prevalent in both the default tag testcontainers uses
hashicorp/vault:1.13.0as well as the latesthashicorp/vault:1.16.1. This patch fixes the tests for both versions encountering the errorjson: cannot unmarshal number into Go struct field AppRoleWriteSecretIdResponse.data.secret_id_ttl of type string.Also, creators of cert-manager/cert-manager#6601 might be interested in this update since it removes their need for using raw workarounds.