Ensured that beta runs in TeamCity use only beta paths #17350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensured that beta runs in TeamCity use only beta paths * Added tests for sweeper package path [upstream:d9c78713a1229b452f880d271f76f8923fa9f76b] Signed-off-by: Modular Magician <[email protected]>
SarahFrench
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Ensured that beta runs in TeamCity use only beta paths * Added tests for sweeper package path [upstream:d9c78713a1229b452f880d271f76f8923fa9f76b] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-d9c78713a1229b452f880d271f76f8923fa9f76b
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sure that all packages used in beta configurations use
google-betain their path instead ofgoogle. I also added tests that I think would catch this issue in the future for sweepers, since that's the problem at hand - I'm also not as confident about how to add tests for the other packages.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10025