Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for inter-VPC communications in router_nat resource #15987

Conversation

modular-magician
Copy link
Collaborator

Fixes: Fixes: #15902

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `type` field to `google_compute_router_nat` resource (beta)
compute: added `rules.action.source_nat_active_ranges` field to `google_compute_router_nat` resource (beta)
compute: added `rules.action.source_nat_drain_ranges` field to `google_compute_router_nat` resource (beta)

Derived from GoogleCloudPlatform/magic-modules#9007

…icorp#9007)

* add support for type field in router_nat resource

* fixing existing tests by sending default_value in the new type field

* adding support for sourceNatActiveRanges to rulesAction field

* adding support for sourceNatDrainRanges to rulesAction field

* enhancing doc test to use private inter vpc

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 5f1083e into hashicorp:main Sep 25, 2023
4 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
@modular-magician modular-magician deleted the downstream-pr-0854b1f18db7b205c6d5ce6a1e91ff5a8bb4d9d4 branch November 17, 2024 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for inter-VPC communications
1 participant