Skip duplication validation for empty cluster IDs (#9018) (#15940)

Signed-off-by: Modular Magician <[email protected]>
hashicorp · Sep 22, 2023 · ff63d88 · ff63d88
1 parent ecdbc28
commit ff63d88
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changelog/9018.txt b/.changelog/9018.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+bigtable: fixed a bug where dynamically created clusters would incorrectly run into duplication error in `google_bigtable_instance`
+```
diff --git a/google/services/bigtable/resource_bigtable_instance.go b/google/services/bigtable/resource_bigtable_instance.go
@@ -545,6 +545,10 @@ func resourceBigtableInstanceUniqueClusterID(_ context.Context, diff *schema.Res
 	for i := 0; i < newCount.(int); i++ {
 		_, newId := diff.GetChange(fmt.Sprintf("cluster.%d.cluster_id", i))
 		clusterID := newId.(string)
+		// In case clusterID is empty, it is probably computed and this validation will be wrong.
+		if clusterID == "" {
+			continue
+		}
 		if clusters[clusterID] {
 			return fmt.Errorf("duplicated cluster_id: %q", clusterID)
 		}