Skip to content

Commit

Permalink
Add google_logging_metric to version 5 upgrade doc for #8780 (#8887)
Browse files Browse the repository at this point in the history
Co-authored-by: Cameron Thornton <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician and c2thorn committed Sep 11, 2023
1 parent 7762094 commit 5d18e15
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/8887.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none
Add google_logging_metric to version 5 upgrade doc for #8780
```
14 changes: 13 additions & 1 deletion website/docs/guides/version_5_upgrade.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,18 @@ If you were relying on accessing an individual flag by index (for example, `goog

Previously, the default value for `rule.rate_limit_options.encorce_on_key` is "ALL", now this field no longer has a default value.

## Resource: `google_logging_metric`

### Additional `bucket_options` subfields are now properly required

When setting the `bucket_options` block, the following fields may be required:

* `num_finite_buckets`, `width`, and `offset` are now required when `bucket_options.linear_buckets` is set.

* `num_finite_buckets`, `growth_factor`, and `scale` are now required when `bucket_options.exponential_buckets` is set.

Previously these fields should have been required but were not, which allowed for invalid `google_logging_metric` configurations.

## Resource: `google_logging_project_sink`

### `unique_writer_identity` now defaults to `TRUE`
Expand Down Expand Up @@ -437,4 +449,4 @@ resource "google_project_iam_binding" "gcs-bucket-writer" {

### `Create` endpoint is used to create the resource

`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.
`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.

0 comments on commit 5d18e15

Please sign in to comment.