Edit pass on upgrade guide for 5.0.0 #6420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cameron Thornton <[email protected]> Signed-off-by: Modular Magician <[email protected]>
c2thorn
added a commit
that referenced
this pull request
Oct 2, 2023
Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Cameron Thornton <[email protected]>
modular-magician
deleted the
downstream-pr-30ac5a8331c6a0fb518d47a84049ba69bcf21ae6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the size of the diff- I reflowed the content I was touching out of habit. I'd like to find a way to automate formatting that stuff so that we can lint for it, similar to internal markdown.
Mainly adds examples, pulls up some impact warnings to the top of the labels rework, and changes tenses. I was going to add a section describing the numerous provider-wide changes as I'd mentioned in our 1:1, but when actually making changes I decided that just duplicating and pulling up the
!>blocks was sufficient.FYI @zli82016 in case you have any comments/thoughts! Most of this was on the upgrade guide for the labels rework.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9142