Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK provider configuration tests, part 3 #6181

Conversation

modular-magician
Copy link
Collaborator

By adding tests for the providerConfigure function we will know what behaviours we need to test for in the plugin framework version of that logic. We want to assert parity between SDK and plugin framework versions of the code.

This PR references that tests that are implemented in #7723

Coverage:

  • batching

    • send_after
    • enable_batching
  • request_timeout

  • request_reason

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#8576

* initial request_timeout test in providerConfigure

* initial requestReason test in providerConfigure

* initial batching test in providerConfigure

* complete requestTimeout test

* complete requestReason test

* batch block testing

* complete batching test

* add more info in test cases

* typos

* remove redundant SDKDefault_RequestReason test

* refactor ExpectedEnableBatchingValue

* add ExpectedSendAfterValue check when enable_batching is only set

* add info about default sendafter value and new edgecase

* add valid request_timeout test case

* Update mmv1/third_party/terraform/provider/provider_internal_test.go

Co-authored-by: Sarah French <[email protected]>

* Update mmv1/third_party/terraform/provider/provider_internal_test.go

Co-authored-by: Sarah French <[email protected]>

* Update mmv1/third_party/terraform/provider/provider_internal_test.go

Co-authored-by: Sarah French <[email protected]>

* Update mmv1/third_party/terraform/provider/provider_internal_test.go

Co-authored-by: Sarah French <[email protected]>

* Update mmv1/third_party/terraform/provider/provider_internal_test.go

Co-authored-by: Sarah French <[email protected]>

* Update mmv1/third_party/terraform/provider/provider_internal_test.go

Co-authored-by: Sarah French <[email protected]>

* add credentials into batching tests

* go fmt

* add missing credentials in config tests

* Add missing refactoring changes, add credentials info

---------

Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 65c0cd4 into hashicorp:main Aug 31, 2023
@modular-magician modular-magician deleted the downstream-pr-ad3a3c9a08d6e9d6ad37600e63e79a931af8df28 branch November 16, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant