Skip to content

Commit

Permalink
Container wording tweaks (#9135) (#6412)
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Sep 29, 2023
1 parent 2dcfc0f commit fbd2d0d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .changelog/9135.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
Original file line number Diff line number Diff line change
Expand Up @@ -4029,7 +4029,7 @@ func resourceContainerClusterUpdate(d *schema.ResourceData, meta interface{}) er

func resourceContainerClusterDelete(d *schema.ResourceData, meta interface{}) error {
if d.Get("deletion_protection").(bool) {
return fmt.Errorf("Cannot destroy cluster because deletion_protection is set to true. Set it to false to proceed with instance deletion.")
return fmt.Errorf("Cannot destroy cluster because deletion_protection is set to true. Set it to false to proceed with cluster deletion.")
}
config := meta.(*transport_tpg.Config)
userAgent, err := tpgresource.GenerateUserAgentString(d, config.UserAgent)
Expand Down
10 changes: 6 additions & 4 deletions website/docs/guides/version_5_upgrade.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -491,13 +491,15 @@ has a default value.

## Resource: `google_container_node_pool`

### `logging_variant` no longer has a provider default value
### `management.auto_repair` and `management.auto_upgrade` now default to true

Previously `logging_variant` defaulted to "DEFAULT". It no longer has a default value.
Previously both fields defaulted to false if `management` was set as an empty block.
They now default to true.

### `management.auto_repair` and `management.auto_upgrade` now default to true
### `logging_variant` no longer has a provider default value

Previously both fields defaulted to false. They now default to true.
The provider no longer shows a default value at plan-time, and defers to the
API server default.

### `node_config.0.taint` field change

Expand Down

0 comments on commit fbd2d0d

Please sign in to comment.