Skip to content

Commit

Permalink
Upgrade guide - google_monitoring_* (#8970) (#6370)
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Sep 25, 2023
1 parent be18352 commit 51ba126
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .changelog/8970.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
16 changes: 16 additions & 0 deletions website/docs/guides/version_5_upgrade.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -516,12 +516,28 @@ resource "google_firestore_database" "default" {
### `deletion_policy` now defaults to `DELETE`

Previously, `google_firebase_web_app` deletions default to `ABANDON`, which means to only stop tracking the WebApp in Terraform. The actual app is not deleted from the Firebase project. If you are relying on this behavior, set `deletion_policy` to `ABANDON` explicitly in the new version.

## Resource: `google_compute_autoscaler` (beta)

### `metric.filter` now defaults to `resource.type = gce_instance`

Previously, `metric.filter` doesn't have the defult value and causes a UI error.

## Resource: `google_monitoring_dashboard`

### `dashboard_json` suppresses removal diffs more aggressively

To prevent permanent diffs from default values, Terraform will now attempt to suppress diffs where the value is returned in the JSON
string but doesn't exist in the configuration. Consequently, legitmate remove-only diffs will also be suppressed.
For Terraform to detect the diff, JSON key removals must also be accompanied by a non-removal change (trivial or not).

## Resource: `google_monitoring_metric_descriptor`

### Changing `labels` now triggers replacement

Previously, attempting to update `labels` failed and created a permadiff. The `labels`
field is now immutable without destroying and recreating the resource.

## Resource: `google_privateca_certificate`

### `config_values` is now removed
Expand Down

0 comments on commit 51ba126

Please sign in to comment.