azurerm_public_ip_prefix: adding sku_tier property

[CorrenSoft]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• Added sku_tier to the resource and the data source.
• Updated TestAccDataSourcePublicIPPrefix_basic to validate the output value.
• Added TestAccPublicIpPrefix_globalTier and TestAccPublicIpPrefix_regionalTier to test both possible values.
• Updated docs.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass.

make acctests SERVICE='network' TESTARGS='-run=TestAccDataSourcePublicIPPrefix_'

=== RUN   TestAccDataSourcePublicIPPrefix_basic
=== PAUSE TestAccDataSourcePublicIPPrefix_basic
=== CONT  TestAccDataSourcePublicIPPrefix_basic
--- PASS: TestAccDataSourcePublicIPPrefix_basic (167.14s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       167.429s

make acctests SERVICE='network' TESTARGS='-run=TestAccPublicIpPrefix_'

=== RUN   TestAccPublicIpPrefix_basic
=== PAUSE TestAccPublicIpPrefix_basic
=== RUN   TestAccPublicIpPrefix_globalTier
=== PAUSE TestAccPublicIpPrefix_globalTier
=== RUN   TestAccPublicIpPrefix_regionalTier
=== PAUSE TestAccPublicIpPrefix_regionalTier
=== RUN   TestAccPublicIpPrefix_ipv6
=== PAUSE TestAccPublicIpPrefix_ipv6
=== RUN   TestAccPublicIpPrefix_requiresImport
=== PAUSE TestAccPublicIpPrefix_requiresImport
=== RUN   TestAccPublicIpPrefix_prefixLength31
=== PAUSE TestAccPublicIpPrefix_prefixLength31
=== RUN   TestAccPublicIpPrefix_prefixLength24
=== PAUSE TestAccPublicIpPrefix_prefixLength24
=== RUN   TestAccPublicIpPrefix_update
=== PAUSE TestAccPublicIpPrefix_update
=== RUN   TestAccPublicIpPrefix_disappears
=== PAUSE TestAccPublicIpPrefix_disappears
=== RUN   TestAccPublicIpPrefix_zonesSingle
=== PAUSE TestAccPublicIpPrefix_zonesSingle
=== RUN   TestAccPublicIpPrefix_zonesMultiple
=== PAUSE TestAccPublicIpPrefix_zonesMultiple
=== CONT  TestAccPublicIpPrefix_basic
=== CONT  TestAccPublicIpPrefix_zonesSingle
=== CONT  TestAccPublicIpPrefix_prefixLength24
=== CONT  TestAccPublicIpPrefix_disappears
=== CONT  TestAccPublicIpPrefix_zonesMultiple
=== CONT  TestAccPublicIpPrefix_ipv6
=== CONT  TestAccPublicIpPrefix_prefixLength31
=== CONT  TestAccPublicIpPrefix_requiresImport
=== CONT  TestAccPublicIpPrefix_regionalTier
--- PASS: TestAccPublicIpPrefix_disappears (475.63s)
=== CONT  TestAccPublicIpPrefix_globalTier
--- PASS: TestAccPublicIpPrefix_requiresImport (484.94s)
=== CONT  TestAccPublicIpPrefix_update
--- PASS: TestAccPublicIpPrefix_zonesSingle (489.34s)
--- PASS: TestAccPublicIpPrefix_ipv6 (497.96s)
--- PASS: TestAccPublicIpPrefix_zonesMultiple (517.30s)
--- PASS: TestAccPublicIpPrefix_prefixLength31 (519.51s)
--- PASS: TestAccPublicIpPrefix_basic (589.28s)
--- PASS: TestAccPublicIpPrefix_regionalTier (293.36s)
--- PASS: TestAccPublicIpPrefix_update (193.22s)
--- PASS: TestAccPublicIpPrefix_globalTier (236.70s)

Note: Missing TestAccPublicIpPrefix_prefixLength24 because is not accepted in my working subscription.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_public_ip_prefix - support for the sku_tier property [Support for configuring SKU tier when creating a Public IP Prefix #27877]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27877

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this @CorrenSoft! This looks good, I just have one question and a suggestion. Once those are resolved this should be good to merge.

[stephybun]

This can be replaced with

Suggested change

	ValidateFunc: validation.StringInSlice([]string{
	string(publicipprefixes.PublicIPPrefixSkuTierGlobal),
	string(publicipprefixes.PublicIPPrefixSkuTierRegional),
	}, false),
	ValidateFunc: validation.StringInSlice(PossibleValuesForPublicIPPrefixSkuTier(), false),

[CorrenSoft]

Lovely, thank you.

[stephybun]

Just confirming here, but Is this the default that existing resources created by Terraform would have?

[CorrenSoft]

Yes, any resource created has that value.

"sku": {
    "name": "Standard",
    "tier": "Regional"
}

[stephybun]

Good stuff, thanks @CorrenSoft LGTM 🧊