New Resource: azurerm_site_recovery_hyperv_replicated_vm

[ziyeqf]

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccSiteRecoveryHyperVReplicatedVM_basic -timeout=600m
=== RUN   TestAccSiteRecoveryHyperVReplicatedVM_basic
=== PAUSE TestAccSiteRecoveryHyperVReplicatedVM_basic
=== CONT  TestAccSiteRecoveryHyperVReplicatedVM_basic
--- PASS: TestAccSiteRecoveryHyperVReplicatedVM_basic (3469.97s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      3470.022s

terraform-provider-azurerm ❯  TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccSiteRecoveryHyperVReplicatedVM_complete -timeout=600m
=== RUN   TestAccSiteRecoveryHyperVReplicatedVM_complete
=== PAUSE TestAccSiteRecoveryHyperVReplicatedVM_complete
=== CONT  TestAccSiteRecoveryHyperVReplicatedVM_complete
--- PASS: TestAccSiteRecoveryHyperVReplicatedVM_complete (3294.71s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      3294.756s

[tombuildsstuff]

hi @ziyeqf

Taking a look through here there appears to be an issue which needs to be fixed in hashicorp/go-azure-sdk, rather than necessarily needing fixing in the Swagger - can you please open an issue there so that we can dig into this?

Thanks!

[tombuildsstuff]

Is there an issue on hashicorp/go-azure-sdk to track this? We can likely workaround this there

[tombuildsstuff]

Looking at the model here, since ReplicationProviderInput is a Discriminated Type that's Optional, as such this:

package main

import (
	"encoding/json"
	"log"

	"github.com/hashicorp/go-azure-sdk/resource-manager/recoveryservicessiterecovery/2022-10-01/replicationprotecteditems"
)

func main() {
	foo := replicationprotecteditems.DisableProtectionInput{}
	out, err := json.Marshal(foo)
	if err != nil {
		log.Fatalf("error: %+v", err)
	}
	log.Printf("JSON: %s", out)
}

Should output:

JSON: {"properties":{}}

But actually outputs:

JSON: {"properties":{"replicationProviderInput":null}}

As such this looks to be something we can workaround in hashicorp/go-azure-sdk - can you open an issue about this, with the full HTTP Requests/Responses so that we can diagnose this?

[ziyeqf]

here you go: hashicorp/go-azure-sdk#387

[ziyeqf]

Just want to confirm if we need to wait for the go-azure-sdk workaround to merge this PR?

[tombuildsstuff]

hey @ziyeqf

Apologies for the delayed response here.

Taking a look through since this continues to be blocked by this issue in hashicorp/pandora rather than leaving this open I'm going to close this PR for the moment - but when the upstream issue is resolved since this is cross-linked we should be able to take another look into this one.

Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.