Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(provider): use hashicorp/setup-terraform in tfproviderdocs check #39510

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 26, 2024

Description

The default ubuntu image no longer includes Terraform by default. We now need to install it at runtime instead.

Relations

Closes #39501
Relates actions/runner-images#10636

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 26, 2024
@jar-b jar-b marked this pull request as ready for review September 26, 2024 20:48
@ewbankkit
Copy link
Contributor

% grep 'terraform ' .github/workflows/*.yml
.github/workflows/examples.yml:          # Needed to use the output of `terraform validate -json`
.github/workflows/examples.yml:            terraform init
.github/workflows/examples.yml:            terraform fmt -check
.github/workflows/examples.yml:            terraform validate
.github/workflows/provider.yml:    name: terraform providers schema
.github/workflows/provider.yml:        name: terraform init
.github/workflows/provider.yml:          terraform init -plugin-dir terraform-plugin-dir
.github/workflows/provider.yml:        name: terraform providers schema
.github/workflows/provider.yml:          terraform providers schema -json > terraform-providers-schema/schema.json
.github/workflows/provider.yml:          terraform -v
.github/workflows/resource-counts.yml:          terraform {
.github/workflows/resource-counts.yml:      - run: terraform init
.github/workflows/resource-counts.yml:          datasources=$(terraform providers schema -json | jq '.provider_schemas[] .data_source_schemas | length')
.github/workflows/resource-counts.yml:          resources=$(terraform providers schema -json | jq '.provider_schemas[] .resource_schemas | length')

It looks like the Resource Counts workflow also needs setup-terraform.

The default ubuntu image no longer includes Terraform by default. We now need to install it at runtime instead.
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 651ccce into main Sep 27, 2024
16 checks passed
@jar-b jar-b deleted the b-tfproviderdocs-ci branch September 27, 2024 14:10
@github-actions github-actions bot added this to the v5.70.0 milestone Sep 27, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: tfproviderdocs task failing
2 participants